Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: omz remote execution if ZSH is not present #592

Merged
merged 3 commits into from
Oct 29, 2023

Conversation

SteveLauC
Copy link
Member

Standards checklist:

  • The PR title is descriptive.
  • I have read CONTRIBUTING.md
  • The code compiles (cargo build)
  • The code passes rustfmt (cargo fmt)
  • The code passes clippy (cargo clippy)
  • The code passes tests (cargo test)
  • Optional: I have tested the code myself

For new steps

  • Optional: Topgrade skips this step where needed
  • Optional: The --dry-run option works with this step
  • Optional: The --yes option works with this step if it is supported by
    the underlying command

If you developed a feature or a bug fix for someone else and you do not have the
means to test it, please tag this person here.

Closes #587

@Un1q32
Copy link

Un1q32 commented Oct 29, 2023

Tested on MacOS 14 and Fedora 38, seems to work fine.
Also tested Fedora 38 with omz installed, works as expected.

@SteveLauC SteveLauC merged commit 7fa38c5 into topgrade-rs:main Oct 29, 2023
@SteveLauC SteveLauC deleted the omz branch October 29, 2023 10:05
@chimeworld
Copy link

Hi, am I correct in saying this change hasn't been released yet? I am affected by this I think.

❯ topgrade -V
Topgrade 13.0.0

@SteveLauC
Copy link
Member Author

Hi, am I correct in saying this change hasn't been released yet? I am affected by this I think.


❯ topgrade -V

Topgrade 13.0.0

Yes, it is still not released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tries and fails oh-my-zsh step, even though oh-my-zsh is not installed, when running in ssh
3 participants