Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch git push and pull order #578

Merged
merged 1 commit into from
Oct 15, 2023
Merged

switch git push and pull order #578

merged 1 commit into from
Oct 15, 2023

Conversation

savente93
Copy link
Contributor

@savente93 savente93 commented Oct 15, 2023

Standards checklist:

  • The PR title is descriptive.
  • I have read CONTRIBUTING.md
  • The code compiles (cargo build)
  • The code passes rustfmt (cargo fmt)
  • The code passes clippy (cargo clippy)
  • The code passes tests (cargo test)
  • Optional: I have tested the code myself

When I implemented this feature I maintained the push pull order for testing and forgot to switch it. Noticing now that this will make the step fail of only pulls are necessary. Switching the order should be good enough for the majority of cases, as it's what git itself suggests.

@SteveLauC
Copy link
Member

Thanks!

@SteveLauC SteveLauC merged commit 6b871e7 into topgrade-rs:main Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants