Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reselect v4 features #62

Conversation

sgrishchenko
Copy link
Contributor

@sgrishchenko sgrishchenko commented Dec 25, 2018

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

feature

What is the current behaviour? (You can also link to an open issue here)

recomputations and dependencies not impelemented

What is the new behaviour?

supported recomputations and dependencies

see https://github.com/reduxjs/reselect/releases/tag/v4.0.0

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

I think so, because the reselect for similar changes made it.

Other information:

see conversation in #60

Please check if the PR fulfills these requirements:

  • Tests for the changes have been added
  • Docs have been added / updated

(cherry picked from commit 6a48e59)
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 2d864f9 on sgrishchenko:reselect-v4-features into 63ab3c4 on toomuchdesign:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 2d864f9 on sgrishchenko:reselect-v4-features into 63ab3c4 on toomuchdesign:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 2d864f9 on sgrishchenko:reselect-v4-features into 63ab3c4 on toomuchdesign:master.

@toomuchdesign toomuchdesign changed the base branch from master to reselect-v4-features December 26, 2018 09:32
@toomuchdesign toomuchdesign merged commit 9d6d8d5 into toomuchdesign:reselect-v4-features Dec 26, 2018
@sgrishchenko sgrishchenko deleted the reselect-v4-features branch January 19, 2019 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants