-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
helpers for datadict #392
helpers for datadict #392
Conversation
wpfff
commented
May 25, 2023
- avoid deepcopy
- meta-object for easier data access
- meta-object for easier data access
makes seeing changes easier.
@marcosfrenkel can you have a look? two main changes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything other than comment looks good, and even the comment is nothing too important.
@marcosfrenkel i fixed the one thing you mentioned. ready to approve? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!