Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ add error #104

Merged
merged 11 commits into from
Jan 17, 2023
Merged

✨ add error #104

merged 11 commits into from
Jan 17, 2023

Conversation

YounesBessa
Copy link
Contributor

No description provided.

@YounesBessa YounesBessa added enhancement New feature or request good first issue Good for newcomers labels Dec 26, 2022
@YounesBessa YounesBessa self-assigned this Dec 26, 2022
@vercel
Copy link

vercel bot commented Dec 26, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
kitchen-docs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 17, 2023 at 1:29PM (UTC)
kitchen-next-typescript ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 17, 2023 at 1:29PM (UTC)

@github-actions
Copy link
Contributor

github-actions bot commented Dec 26, 2022 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/kitchen/dist/tonightpass-kitchen.cjs.prod.js 269.42 KB (+0.16% 🔺) 5.4 s (+0.16% 🔺) 4.7 s (+6.21% 🔺) 10.1 s
packages/kitchen/dist/tonightpass-kitchen.esm.js 91.01 KB (+0.6% 🔺) 1.9 s (+0.6% 🔺) 2 s (+93.56% 🔺) 3.8 s
packages/kitchen/next/dist/tonightpass-kitchen-next.cjs.prod.js 26 KB (0%) 520 ms (0%) 944 ms (-9.8% 🔽) 1.5 s
packages/kitchen/next/dist/tonightpass-kitchen-next.esm.js 25.18 KB (0%) 504 ms (0%) 925 ms (+14.01% 🔺) 1.5 s
packages/kitchen/native/dist/tonightpass-kitchen-native.cjs.prod.js 28.07 KB (0%) 562 ms (0%) 926 ms (+3.24% 🔺) 1.5 s
packages/kitchen/native/dist/tonightpass-kitchen-native.esm.js 27.84 KB (0%) 557 ms (0%) 770 ms (+28.17% 🔺) 1.4 s

@YounesBessa YounesBessa linked an issue Dec 26, 2022 that may be closed by this pull request
Add Error #88
Closed
2 tasks
AntoineKM
AntoineKM reviewed Dec 26, 2022
View reviewed changes
Copy link
Member

@AntoineKM AntoineKM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
image
image

jerembdn
jerembdn requested changes Dec 28, 2022
View reviewed changes
Copy link
Member

@jerembdn jerembdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L'icone error est pas alignée avec le texte (ou la première ligne)

AntoineKM
AntoineKM requested changes Dec 29, 2022
View reviewed changes
Copy link
Member

@AntoineKM AntoineKM left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Icon still too small by default

@AntoineKM AntoineKM removed the good first issue Good for newcomers label Dec 29, 2022
@AntoineKM AntoineKM mentioned this pull request Jan 17, 2023
Open
@AntoineKM AntoineKM requested a review from jerembdn January 17, 2023 13:16
@AntoineKM AntoineKM merged commit 0b07857 into develop Jan 17, 2023
@AntoineKM AntoineKM deleted the younesbessa/error branch January 17, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AntoineKM AntoineKM AntoineKM approved these changes

@jerembdn jerembdn Awaiting requested review from jerembdn

Assignees

@AntoineKM AntoineKM

@YounesBessa YounesBessa

Labels
enhancement New feature or request
Projects
Kitchen Plan
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Error
3 participants
@YounesBessa @jerembdn @AntoineKM