Fixes for deprecated functions #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tomsdev The readme says you are looking for people to make this work with the newest version of Brackets, and that is what I have here for you. Do you want to take a look at it? :) |
|
Thanks a lot for your contribution and sorry for the delay, I didn't receive any notification before you commented.. |
tomsdev
added a commit
that referenced
this pull request
Sep 12, 2014
Fixes for deprecated functions
|
@tomsdev No problem, it happens to all of us. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #13 and fixes #10, though the latter is going solely by the comments made in the issue. This might also solve #12, but I am unsure (if it does, it means your unit tests now work with SplitView).
I figured I'd make these changes as they comprise the majority of the incompatibility this extension has with the newest versions of Brackets, and gives the next person who wants to help fix this a few less things to do. :)