-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
get error with typescript 5 #19
Comments
…roken Need to make some decisions about whether/how to emit CJS modules, because as long as we have verbatimModuleSyntax enabled, we cannot use the typical `export const = "x"` format, and tsc-multi rewriting is also now breaking for this on v5, and patching it to do the rewrites may be non trivial since it can involve shifting large blocks of code. Alternatively we could just not opt into the flag, in which case we should also restore the `isolatedModules` flag (which was removed as redunant). See: * https://devblogs.microsoft.com/typescript/announcing-typescript-5-0/#verbatimmodulesyntax * microsoft/TypeScript#52203 * tommy351/tsc-multi#19
I'm seeing the same, although I'm not sure if it's limited to particular Given the changes in TS5.0 to That said, I do love this little tool. It made my configs a lot more DRY and saved me from writing some hacky build scripts. |
I think the reason is the function signature changes of Commit: 20d7e26 |
|
…roken Need to make some decisions about whether/how to emit CJS modules, because as long as we have verbatimModuleSyntax enabled, we cannot use the typical `export const = "x"` format, and tsc-multi rewriting is also now breaking for this on v5, and patching it to do the rewrites may be non trivial since it can involve shifting large blocks of code. Alternatively we could just not opt into the flag, in which case we should also restore the `isolatedModules` flag (which was removed as redunant). See: * https://devblogs.microsoft.com/typescript/announcing-typescript-5-0/#verbatimmodulesyntax * microsoft/TypeScript#52203 * tommy351/tsc-multi#19
Works great, thanks! |
When I use typescript 5, I get the error in compiler mjs (cjs is ok):
Error: Debug Failure. Unhandled SyntaxKind: ImportClause.
This setting is ok when I use typescript 4
(only get wran: DeprecationWarning: 'createImportDeclaration' has been deprecated since v4.8.0. Decorators are no longer supported for this function. Callers should switch to an overload that does not accept a 'decorators' parameter.)
tsc-multi.json
The text was updated successfully, but these errors were encountered: