feat: Adding ability to define a custom AzureEnvironment. #2579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thank you for your contribution! 🙏 We will review it as soon as possible. |
tomkerkhove
requested changes
Nov 29, 2024
Suraiya-Hameed
force-pushed
the
addCustomAzureEnv
branch
from
1ade4bd to
19d0186
Compare
kevand900
changed the title
|
@tomkerkhove can you please review this PR again? I can open a PR in docs repo if this looks good |
|
/azp run "Promitor CI - Scraper Agent" |
|
No pipelines are associated with this pull request. |
|
Can you please sign off the CLA? |
tomkerkhove
reviewed
Feb 3, 2025
src/Promitor.Agents.ResourceDiscovery/Configuration/AzureLandscape.cs
Outdated
Show resolved
Hide resolved
src/Promitor.Agents.ResourceDiscovery/Graph/AzureResourceGraph.cs
Outdated
Show resolved
Hide resolved
src/Promitor.Agents.ResourceDiscovery/Validation/Steps/AzureLandscapeValidationStep.cs
Outdated
Show resolved
Hide resolved
src/Promitor.Agents.Scraper/Validation/Steps/MetricsDeclarationValidationStep.cs
Outdated
Show resolved
Hide resolved
src/Promitor.Core.Scraping/Configuration/Model/AzureMetadata.cs
Outdated
Show resolved
Hide resolved
Suraiya-Hameed
force-pushed
the
addCustomAzureEnv
branch
from
a944384 to
b051f68
Compare
tomkerkhove
reviewed
Feb 6, 2025
src/Promitor.Agents.ResourceDiscovery/Validation/Steps/AzureLandscapeValidationStep.cs
Outdated
Show resolved
Hide resolved
src/Promitor.Agents.Scraper/Validation/Steps/MetricsDeclarationValidationStep.cs
Outdated
Show resolved
Hide resolved
src/Promitor.Core.Scraping/Configuration/Serialization/v1/Core/AzureEndpointsDeserializer.cs
Outdated
Show resolved
Hide resolved
tomkerkhove
reviewed
Feb 7, 2025
src/Promitor.Agents.ResourceDiscovery/Extensions/AzureLandscapeExtensions.cs
Outdated
Show resolved
Hide resolved
src/Promitor.Agents.Scraper/Extensions/AzureMetaDataExtensions.cs
Outdated
Show resolved
Hide resolved
Suraiya-Hameed
force-pushed
the
addCustomAzureEnv
branch
from
0f617bc to
f729cc4
Compare
Suraiya-Hameed
force-pushed
the
addCustomAzureEnv
branch
from
d9ffdc7 to
e9fa5db
Compare
tomkerkhove
approved these changes
Feb 12, 2025
...Unit/Validation/Scraper/Metrics/ResourceTypes/LogAnalyticsDeclarationValidationStepsTests.cs
Show resolved
Hide resolved
Suraiya-Hameed
added a commit
to Suraiya-Hameed/docs
that referenced
this pull request
Feb 12, 2025
Suraiya-Hameed
added a commit
to Suraiya-Hameed/docs
that referenced
this pull request
Feb 12, 2025
tomkerkhove
approved these changes
Feb 12, 2025
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Thanks a ton!! |
auto-merge was automatically disabled
February 12, 2025 19:21
Head branch was pushed to by a user without write access
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for a custom azure environment whose endpoints can be defined via environment variables in a helm values file. This creates the ability to deploy to new regions without requiring code changes.