Optional thread binding #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- rpyc.core.protocol.Connection.serve: changed to start controlled race with thread from thread pool - rpyc.core.protocol.Connection.serve: fixed bug related to threads continue waiting after close
…lExecutor and reduced thread switching
|
I'm going to merge this in and work on it from there. |
|
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #491
I'm quite happy with the result from a technical perspective (complexity of implementation, performance, potential issues, ...). It solves the motivating problem in #491, behaves nicely in #491 (comment) and avoids a race condition that haunted rpyc for a long time (#492 (comment)).
Regarding threads vs async, consider nogil. Threads in Python might have a bright future after all. Until then, the best argument imo still is transparency.
obviously missing: