Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MarkerClusterer images and others are broken due to google-maps-utility-library-v3 moving to github #255

Closed
pirate opened this issue May 11, 2016 · 11 comments

Comments

@pirate
Copy link
Contributor

pirate commented May 11, 2016

Since google code is shutting down, google has moved their utility library from Google Code to github:

Images urls pointing to their old library no longer work, and will have to be changed, e.g.:

http://google-maps-utility-library-v3.googlecode.com/svn/trunk/markerclustererplus/images/m2.png

to
https://raw.githubusercontent.com/googlemaps/v3-utility-library/master/markerclustererplus/images/m2.png

Although ideally there should be an option to let the user self-host them so this doesn't happen again.

@ghost
Copy link

ghost commented May 12, 2016

There is option to self-host the markers. Just set the imagePath prop.

From docs:

@Property {string} [imagePath=MarkerClusterer.IMAGE_PATH]

  • The full URL of the root name of the group of image files to use for cluster icons.
  • The complete file name is of the form imagePathn.imageExtension
  • where n is the image file number (1, 2, etc.).

This works for me (both absolute or relative is fine):

<MarkerCluster imagePath="./path/to/clusters/m" />

@pirate
Copy link
Contributor Author

pirate commented May 12, 2016

Cool, thanks! I should've checked the docs before mentioning the self-hosting bit. The default URLs are still broken though, so I'll leave this ticket open for now.

@wedneyyuri
Copy link

Is there any open pull request about this?

@pirate
Copy link
Contributor Author

pirate commented May 14, 2016

What's curious is that the string google-maps-utility-library-v3.googlecode.com only exists in commented form in this repo, which makes me think the URL is being dynamically loaded somehow through some google library. I think we have to find the source of whatever library is loading it and fix it there instead of in this repo.

@ghost
Copy link

ghost commented May 15, 2016

@wedneyyuri nope

@pirate This project has marker-clusterer-plus as a dependency. There you can find the hardcoded, dead url.

@pirate
Copy link
Contributor Author

pirate commented May 15, 2016

Thanks for the pointer @11th. @wedneyyuri I just opened a PR to fix it: mikesaidani/marker-clusterer-plus#2

pirate added a commit to pirate/react-google-maps that referenced this issue May 18, 2016
@pirate
Copy link
Contributor Author

pirate commented May 18, 2016

#259 closes this issue (but we cant merge it until @mikesaidani merges mikesaidani/marker-clusterer-plus#3)

@mikesaidani
Copy link

Hello guys,

I just published the new version to NPM. Sorry for the inconvenience.
@pirate Thanks for all the efforts :)

Cheers,
Mike

@tomchentw
Copy link
Owner

Published v4.10.2. Thanks to @11th, @pirate, @wedneyyuri and @mikesaidani !

We're also looking for maintainers. Involve in #266 to help strengthen our community!

@doubleoevan
Copy link

Might want to update this example page so people know that cluster markers are back :) http://react-google-maps.tomchentw.com/#/addons/marker-clusterer?_k=zvrnxa

@tomchentw
Copy link
Owner

@doubleoevan a PR is welcomed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants