Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Doesn't trigger input or change event #6

Closed
jamesjjk opened this issue Feb 4, 2016 · 11 comments
Closed

Doesn't trigger input or change event #6

jamesjjk opened this issue Feb 4, 2016 · 11 comments

Comments

@jamesjjk
Copy link

jamesjjk commented Feb 4, 2016

Hey really cool component but it doesn't fire the input or change event of medium editor when having selected a mention.. Any ideas?

@tomchentw
Copy link
Owner

Uh.. interesting. I'm listening editableInput event and it works.

medium.subscribe("editableInput", function (e) {

@jamesjjk
Copy link
Author

jamesjjk commented Feb 9, 2016

@tomchentw I'm listening to the same event, however it is not being fired on calling selectMentionCallback

Furthermore I have noticed an error being thrown when I use a trigger as the first keyed input.. Uncaught TypeError: Cannot read property 'appendChild' of null

self.editor.subscribe('editableInput', (e) => {
              self._updated = true;
              console.log('trigger')
              self.change(dom.innerHTML);
          });

@tomchentw
Copy link
Owner

@jamesjjk you're right. I'll issue a PR.

@tomchentw
Copy link
Owner

@jamesjjk could you help to review on #7 , thanks!

@jamesjjk
Copy link
Author

@tomchentw will check it out!

@jamesjjk
Copy link
Author

@tomchentw Hi you didn't update the libs.. can't test the updated code in production.

@tomchentw
Copy link
Owner

@jamesjjk I compiled lib and pushed it to the branch.

@jamesjjk
Copy link
Author

@tomchentw I can confirm it works correctly in production. Thanks!

@jamesjjk
Copy link
Author

#7 b6eadaa

@tomchentw
Copy link
Owner

Great!

@tomchentw
Copy link
Owner

Released v2.2.3.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants