Add custom exception retry handling #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tolstislon do you publish the latest version yourself to pypi? I dont see anything in the workflows to do that? could you push up the latest version with these changes? |
|
@dsayling I apologize for the delay https://pypi.org/project/testrail-api/1.11.0/ |
|
No worries. Most appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #71
Uses the existing retry logic around the KeyError. If custom exceptions are passed, the KeyError is combined with the provided tuple. Else, we just retry on the KeyError as the function did before.
Not sure what version you want to mark this, but I can remove/update the version bump as you see fit. Per SemVer, I would assume this is backward compatible features, bumping the minor version.