Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix delete cases #62

Merged
merged 6 commits into from
Apr 16, 2022
Merged

Fix delete cases #62

merged 6 commits into from
Apr 16, 2022

Conversation

dsayling
Copy link
Contributor

The delete_cases function was not taking in any case ids to be deleted and was not formatting the path for the post correctly based on the docs.

See here: https://www.gurock.com/testrail/docs/api/reference/cases/#deletecases

The delete_cases function was not taking in any case ids to be deleted and was not formatting the path for the post correctly based on the docs.

See here: https://www.gurock.com/testrail/docs/api/reference/cases/#deletecases
@dsayling
Copy link
Contributor Author

👋 @tolstislon - let me know if you'd like any changes

@dsayling
Copy link
Contributor Author

I’ll fix the formatting errors later today. What I get for trying to make the change in the online editor.

@dsayling
Copy link
Contributor Author

dsayling commented Mar 3, 2022

@tolstislon sorry that took a few days, flake8 fixed

@dsayling
Copy link
Contributor Author

dsayling commented Mar 3, 2022

Just checked the workflow and will update the unittests that will run too

@dsayling dsayling marked this pull request as draft March 3, 2022 16:18
@dsayling dsayling marked this pull request as ready for review March 3, 2022 16:45
@dsayling
Copy link
Contributor Author

dsayling commented Mar 3, 2022

unittests updated

@dsayling
Copy link
Contributor Author

dsayling commented Mar 7, 2022

@tolstislon I'm not sure why but all of the unittests failed
image
They were passing locally for me.

@dsayling
Copy link
Contributor Author

dsayling commented Apr 1, 2022

@tolstislon - any help would be appreciated here

@tolstislon
Copy link
Owner

@dsayling rebase please

@tolstislon tolstislon merged commit 0687e3b into tolstislon:master Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants