use native json marshaling to map stubbed output #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an output field had a '_' in its name, it was not mapped correctly by 'mapstructure' to the protoc generated class because, in this class, the fields are translated in CamelCase. Hower, the fields have json tag with their original name. Json marshalling is then the way to fix this issue.
|
Thanks @vincent-raman for the PR. |
|
Hi, I modified the basic example, does it seem ok for you ? |
|
LGTM! thanks |
|
I ran into this today, as it introduced a regression for my stubs generated with https://github.com/scalapb/scalapb-json4s. What's surprising me is that the canonical proto3 encoding defaults to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an output field had a '_' in its name, it was not mapped
correctly by 'mapstructure' to the protoc generated class because,
in this class, the fields are translated in CamelCase.
Hower, the fields have json tag with their original name.
Json marshalling is then the way to fix this issue.
Fixes tokopedia/gripmock/#46