Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support multiple stubs in a file #129

Merged
merged 1 commit into from
Feb 17, 2023
Merged

feat: support multiple stubs in a file #129

merged 1 commit into from
Feb 17, 2023

Conversation

yosiaadijaya
Copy link
Contributor

Motivation

there are too many stub files because gripmock can only read 1 stub in 1 file

Changes

  • detect array json and unmarshal to array
  • change storeStub and readStubFromFile into methods for isolated test
  • change unit test to prevent intermittent test fail due to map order

jekiapp
jekiapp requested changes Feb 10, 2023
View reviewed changes
Copy link
Contributor

@jekiapp jekiapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add integration test in the example/simple folder

@yosiaadijaya yosiaadijaya force-pushed the support_multi_stub_file branch from 75a1b6a to 4dfca9e Compare February 14, 2023 08:50
@jekiapp jekiapp merged commit edac53a into master Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jekiapp jekiapp jekiapp requested changes

@anggimharahap anggimharahap anggimharahap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yosiaadijaya @jekiapp @anggimharahap