Add styles to support printing the tutorial #771
+40
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. I tried it and it looks ok. However, there's a CI failure due to the "prettier" formatter. |
sruggier
force-pushed
the
pr/add-print-styles
branch
from
9d23a80 to
71c5c32
Compare
|
Thanks, it should be fixed now. I also added a bit of detail to the first commit's subject and description. |
|
@Darksonn Would you mind re-approving the CI workflow? It should pass now. |
|
@sruggier I just re-ran tests. (It seems that some tests are still failing, though) |
sruggier
force-pushed
the
pr/add-print-styles
branch
from
71c5c32 to
666e62d
Compare
sruggier
force-pushed
the
pr/add-print-styles
branch
from
666e62d to
daa9dfe
Compare
This makes it much easier to export the documentation to PDF or paper for offline reading.
The scroll bars are fine in a browser, but not so useful in a PDF file or on a printed page.
sruggier
force-pushed
the
pr/add-print-styles
branch
from
daa9dfe to
6e26f7c
Compare
mox692
reviewed
Feb 18, 2025
| @@ -79,6 +79,7 @@ $footer-background-color: black; | |||
| $footer-color: white; | |||
|
|
|||
| @import "../node_modules/bulma/bulma.sass"; | |||
| @import "../node_modules/bulma-print/bulma-print"; | |||
There was a problem hiding this comment.
Apparently, what this import refers to is just a few lines of CSS, so I think we can simply paste it inline in styles/styles.scss rather than adding bulma-print. What do you think?
(Also, it seems that bulma-print library hasn't been updated for some time.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to save an offline copy of the tutorial to PDF or paper.