Handle host bounce after crash #90
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Hey Konrad.
Nice change! I've took different route initially but end up with the same solution as you.
I might have overdone it with refactoring in #89
I don't mind to go with your change. Let see what reviewers will say about refactoring I've done.
-Sergii
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #88 .
We start storing handle as an
Optionfor bothClientandSimulated.Option for Client is to simplify the
block_oncode, its not necessary.It allows to store additional data in the runtimes, as they are no longer being removed when finished.
I guess I was doing it in parallel with @tereshch-aws (#89 ), but I did not refactor nor extract. Wanted to show my solution.