Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove double quote for env_filter directive comment #3192

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

leavesster
Copy link

Motivation

The docs about env_filter about target[span{field=value}]=level Directives has some type error.

the [script{source=\"stdout\"]=trace won't match the log below:

2025-01-14T08:54:02.550867Z  INFO script{source="stdout"}: trac: output to stdout: 131

but [script{source=stdout]=trace will match.

It seems the double quote will be part of the field's value.

Solution

just remove double quote and \

@leavesster leavesster requested review from hawkw, davidbarsky and a team as code owners January 14, 2025 08:57
@leavesster leavesster changed the title docs: double quote will treated as a part of field value docs: remove double quote for env_filter directive comment Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant