subscriber: update minimum tracing-core dep to 0.1.28
#2190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #2008 added a new method to the `tracing_core::Subscriber` trait, and modified `tracing-subscriber` to and implement that method. However, that PR did *not* increase the minimum `tracing-core` dependency for the `tracing-subscriber` crate. This means that if a dependent of `tracing-subscriber` updates *only* `tracing-subscriber` dependency version (e.g. by running `cargo update -p tracing-subscriber`), it will not also update its `tracing-core` version to one that contains the new method, and `tracing-subscriber` will fail to compile. This is a common occurence with projects using Dependabot, for example. This commit updates `tracing-subscriber`'s minimum `tracing-core` dep to 0.1.28. Once this merges, I'll release 0.3.13 of `tracing-subscriber` and yank 0.3.12.
carllerche
approved these changes
Jun 30, 2022
hawkw
added a commit
that referenced
this pull request
Jun 30, 2022
# 0.3.13 (Jun 30, 2022) This release of `tracing-subscriber` fixes a compilation failure due to an incorrect `tracing-core` dependency that was introduced in v0.3.12. ### Changed - **tracing_core**: Updated minimum dependency version to 0.1.28 (#2190)
hawkw
added a commit
that referenced
this pull request
Jun 30, 2022
# 0.3.13 (Jun 30, 2022) This release of `tracing-subscriber` fixes a compilation failure due to an incorrect `tracing-core` dependency that was introduced in v0.3.12. ### Changed - **tracing_core**: Updated minimum dependency version to 0.1.28 (#2190)
kaffarell
pushed a commit
to kaffarell/tracing
that referenced
this pull request
May 22, 2024
# 0.3.13 (Jun 30, 2022) This release of `tracing-subscriber` fixes a compilation failure due to an incorrect `tracing-core` dependency that was introduced in v0.3.12. ### Changed - **tracing_core**: Updated minimum dependency version to 0.1.28 (tokio-rs#2190)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
PR #2008 added a new method to the
tracing_core::Subscribertrait, andmodified
tracing-subscriberto and implement that method. However,that PR did not increase the minimum
tracing-coredependency for thetracing-subscribercrate.This means that if a dependent of
tracing-subscriberupdates onlytracing-subscriberdependency version (e.g. by runningcargo update -p tracing-subscriber), it will not also update itstracing-coreversion to one that contains the new method, andtracing-subscriberwill fail to compile. This is a common occurrencewith projects using Dependabot, for example.
Solution
This commit updates
tracing-subscriber's minimumtracing-coredep to0.1.28. Once this merges, I'll release 0.3.13 of
tracing-subscriberand yank 0.3.12.