async-await: update to new future/task API #919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This rewrites noop_waker with items from the new API and replaces LocalWaker with Waker. This also bumps the minimum required version of tokio-async-await to 1.34.0-nightly. Fixes: #908
Unpin was added to std prelude.
This will check if it can compile using the latest future/task API. Since this build is allowed to fail, it will not affect other PRs.
|
The new noop_waker implementation is based on the new noop_waker of futures-rs (this changed in rust-lang/futures-rs#1445). |
This was referenced Feb 22, 2019
carllerche
approved these changes
Feb 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
future/task API updated in rust-lang/rust#57992.
Solution
Rewrites the noop_waker with items from the new API and replaces LocalWaker with Waker.
This also bumps the minimum required version of tokio-async-await to 1.34.0-nightly.
Fixes: #908