Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: prepare for v0.3.0 release #2960

Merged
merged 6 commits into from
Oct 15, 2020
Merged

chore: prepare for v0.3.0 release #2960

merged 6 commits into from
Oct 15, 2020

Conversation

carllerche
Copy link
Member

@carllerche carllerche commented Oct 14, 2020 •
edited
Loading

This will be merged tomorrow.

Darksonn
Darksonn reviewed Oct 14, 2020
View reviewed changes
Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to change tokio-macros to a non-path dependency.

tokio/CHANGELOG.md Outdated Show resolved Hide resolved
paolobarbolini
paolobarbolini reviewed Oct 14, 2020
View reviewed changes
tokio/CHANGELOG.md Outdated Show resolved Hide resolved
@paolobarbolini paolobarbolini mentioned this pull request Oct 14, 2020
Merged
taiki-e
taiki-e reviewed Oct 14, 2020
View reviewed changes
tokio/CHANGELOG.md Outdated Show resolved Hide resolved
alce
alce reviewed Oct 14, 2020
View reviewed changes
tokio/CHANGELOG.md Outdated Show resolved Hide resolved
taiki-e
taiki-e reviewed Oct 14, 2020
View reviewed changes
tokio/CHANGELOG.md Outdated Show resolved Hide resolved
@carllerche
Copy link
Member Author

@Darksonn

You need to change tokio-macros to a non-path dependency.

I think that this has to happen post release as tokio-macros 0.3 isn't out yet.

@carllerche carllerche marked this pull request as ready for review October 14, 2020 21:05
LucioFranco
LucioFranco approved these changes Oct 14, 2020
View reviewed changes
Copy link
Member

@LucioFranco LucioFranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nice to do otherwise LGTM

tokio-util/CHANGELOG.md Show resolved Hide resolved
@carllerche carllerche merged commit 12f1dff into master Oct 15, 2020
@carllerche carllerche deleted the prepare-0.3-release branch October 15, 2020 16:22
@taiki-e taiki-e mentioned this pull request Oct 31, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alce alce alce left review comments

@Darksonn Darksonn Darksonn left review comments

@LucioFranco LucioFranco LucioFranco approved these changes

@paolobarbolini paolobarbolini paolobarbolini left review comments

@taiki-e taiki-e taiki-e left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@carllerche @alce @Darksonn @LucioFranco @paolobarbolini @taiki-e