Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix ci failure on v0.1.x #2608

Merged
merged 2 commits into from
Jun 11, 2020
Merged

ci: fix ci failure on v0.1.x #2608

merged 2 commits into from
Jun 11, 2020

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Jun 10, 2020

Motivation

Backport #2403
Addresses #2563 (comment)

Solution

@taiki-e taiki-e added T-v0.1.x Topic: tokio 0.1.x A-ci Area: The continuous integration setup labels Jun 10, 2020
@taiki-e taiki-e requested a review from Darksonn June 10, 2020 23:51
@taiki-e
Copy link
Member Author

taiki-e commented Jun 11, 2020

I think the CI failure is due to MSRV bump of crossbeam, but I'm not sure why it was released. It shouldn't have been released yet (IIRC it should have been one of the PRs done as one of the breaking changes for v1.0).

@taiki-e
Copy link
Member Author

taiki-e commented Jun 11, 2020

Oh, I resolved crossbeam issue, but there is another issue:

An image label with the label macOS-10.13 does not exist.

https://dev.azure.com/tokio-rs/Tokio/_build/results?buildId=6053&view=logs&jobId=599d3a74-21de-5895-d5f3-2c3ca460a9ba&j=599d3a74-21de-5895-d5f3-2c3ca460a9ba

@taiki-e taiki-e added the S-waiting-on-author Status: awaiting some action (such as code changes) from the PR or issue author. label Jun 11, 2020
macOS-10.13 has been removed.
@taiki-e taiki-e changed the title ci: fix FreeBSD CI (v0.1.x) ci: fix ci failure on v0.1.x Jun 11, 2020
@taiki-e taiki-e removed the S-waiting-on-author Status: awaiting some action (such as code changes) from the PR or issue author. label Jun 11, 2020
Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@taiki-e taiki-e merged commit 048628b into tokio-rs:v0.1.x Jun 11, 2020
@taiki-e taiki-e deleted the v0.1-freebsd branch June 11, 2020 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ci Area: The continuous integration setup T-v0.1.x Topic: tokio 0.1.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants