Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yield now docs #2129

Merged
merged 3 commits into from
Jan 20, 2020
Merged

Yield now docs #2129

merged 3 commits into from
Jan 20, 2020

Conversation

dekellum
Copy link
Contributor

Motivation

Based on a URLO thread and discord conversation with @hawkw and @Matthias247, I learned a great deal about what tokio::task::yield_now does, noticing that the rustdoc for that method can be improved.

Solution

rustdoc-o

@dekellum dekellum marked this pull request as ready for review January 17, 2020 21:05
@dekellum dekellum requested a review from hawkw January 17, 2020 21:05
Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thank you!

tokio/src/task/yield_now.rs Show resolved Hide resolved
tokio/src/task/yield_now.rs Show resolved Hide resolved
@dekellum
Copy link
Contributor Author

dekellum commented Jan 20, 2020

@carllerche or @LucioFranco or @hawkw ? Could I get a merge of this before it conflicts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants