Add support for zero copy sendmsg. #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrankReh
requested changes
Jan 17, 2023
FrankReh
requested changes
Jan 17, 2023
ollie-etl
reviewed
Jan 17, 2023
FrankReh
requested changes
Jan 18, 2023
FrankReh
requested changes
Jan 18, 2023
There was a problem hiding this comment.
Nice. Probably two outstanding questions on my part. Thanks for this. I think it's time we asked @Noah-Kennedy for a review too. (I haven't run this through CI because I'm assuming it compiles and there are no new tests.)
ollie-etl
reviewed
Jan 20, 2023
|
@FrankReh Are all of your concerns addressed? |
ollie-etl
added a commit
to ollie-etl/tokio-uring
that referenced
this pull request
Jan 20, 2023
FrankReh
reviewed
Jan 20, 2023
FrankReh
approved these changes
Jan 20, 2023
There was a problem hiding this comment.
Thanks. Looks very good. I wish we have a test case or some sample of a test case attached to this PR so when we were ready to test with a 6.1 kernel, it would be easy for somebody new to know what to add. But it is ready to merge anyway. Just going to give @Noah-Kennedy a chance at feedback before I merge in a few hours. I realize it doesn't break or change any existing functionality anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the IORING_OP_SENDMSG_ZC opcode added in Linux 6.1 with a new sendmsg_zc function for UDP sockets.