rt: refactor driver, runtime, and op #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This cleans up a few different pieces and is a followup change from #196.
FrankReh
requested changes
Dec 4, 2022
| let _guard = tokio_rt.enter(); | ||
| let async_driver_handle = AsyncFd::new(driver).unwrap(); | ||
|
|
||
| local.spawn_local(drive_uring_wakes(async_driver_handle)); |
There was a problem hiding this comment.
If I may, I think 'driver' is still being used too much. Everything is a driver. Then nothing is. 😄
There was a problem hiding this comment.
Yeah, we should probably rename a bunch of the driver vars to driver_handle.
|
@Noah-Kennedy Oh, also make clippy happy. |
|
@FrankReh could you take a re-review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up a few different pieces and is a followup change from #196.