runtime: remove needless 'static bounds #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current_thread runtime's `block_on` and `block_on_std` functions have `'static` bounds on the input future type. These are unnecessary, since the inner tokio 0.2 runtime doesn't require these bounds, and they aren't required by tokio 0.1, breaking API compatibility. Signed-off-by: Eliza Weisman <[email protected]>
Similarly, futures passed to the threadpool's `run` also don't need `'static` bounds. This commit removes them. Signed-off-by: Eliza Weisman <[email protected]>
LucioFranco
approved these changes
Jan 6, 2020
Signed-off-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
hawkw
added a commit
that referenced
this pull request
Jan 7, 2020
Fixed: - Removed unnecessary `'static` bounds on the `current_thread` runtime's `block_on`/`block_on_std` functions that broke API compatibility with Tokio 0.1 (#17) Added: - Implementation of `futures` 0.1 `Executor` trait for `TaskExecutor`s (#18) Signed-off-by: Eliza Weisman <[email protected]>
hawkw
added a commit
that referenced
this pull request
Jan 8, 2020
Fixed: - Removed unnecessary `'static` bounds on the `current_thread` runtime's `block_on`/`block_on_std` functions that broke API compatibility with Tokio 0.1 (#17) Added: - Implementation of `futures` 0.1 `Executor` trait for `TaskExecutor`s (#18) Signed-off-by: Eliza Weisman <[email protected]>
jatsrt
reviewed
Jan 10, 2020
| @@ -169,7 +167,7 @@ where | |||
| F: Future<Output = ()> + Send + 'static, | |||
| { | |||
| let mut runtime = Runtime::new().expect("failed to start new Runtime"); | |||
| runtime.block_on_std(future); | |||
There was a problem hiding this comment.
This change caused a breaking change for us. Not sure that was intended, but in certain scenarios our futures would never return.
There was a problem hiding this comment.
@jatsrt as I mentioned in 1f2137b#commitcomment-36749058, that definitely wasn't intended — this wasn't supposed to cause any change in behavior. Can you open a new issue (with example code that reproduces this, if possible?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current_thread runtime's
block_onandblock_on_stdfunctionshave
'staticbounds on the input future type. These are unnecessary,since the inner tokio 0.2 runtime doesn't require these bounds, and they
aren't required by tokio 0.1, breaking API compatibility.
Similarly, futures passed to the threadpool's
runalso don't need'staticbounds. This commit removes them.Signed-off-by: Eliza Weisman [email protected]