refactor(sqlite): fix some warnings #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
open-schnick
commented
Oct 25, 2024
| sql::Statement::Update(u) if u.pre_condition.is_some() => false, | ||
| _ => true, | ||
| }; | ||
| let exec = !matches!(sql, sql::Statement::Update(u) if u.pre_condition.is_some()); |
There was a problem hiding this comment.
maybe one could rename the variable to make it express the actual meaning behind not executing the query in some cases
There was a problem hiding this comment.
actually i am not really sure what the code means ^^
we dont exec when the sql is not an Statement::Update or an Statement::Update without a pre_condition
renaming exec to something more meaningful would make the code more readable i think
There was a problem hiding this comment.
When exec is true, call stmt.execute. When exec is false, call stmt.query). (i.e true is call the execute method).
open-schnick
force-pushed
the
refactor/fix-warnings
branch
from
5d3074a to
50bb545
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.