Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nix api for version 0.7.1 and later #487

Closed
wants to merge 1 commit into from

Conversation

asomers
Copy link
Collaborator

@asomers asomers commented Oct 24, 2016

Git rev 45c82235a3b91939ea9a656c6afcf71be15411f3, to be released in
Nix 0.7.1 or later, changes the API of KEvent.

nix-rust/nix#442 must be merged before this PR will build.

Git rev 45c82235a3b91939ea9a656c6afcf71be15411f3, to be released in
Nix 0.7.1 or later, changes the API of KEvent.
@alexcrichton
Copy link
Contributor

Thanks for the PR! Right now master of this repo is the 0.6 release of mio, so we're hoping to not introduce git dependencies as that would block another point release of mio. Perhaps though this could be updated once the changes to nix are merged?

@asomers
Copy link
Collaborator Author

asomers commented Oct 31, 2016

In fact, the changes to nix just got merged yesterday. Or do you mean we should update this PR once nix has a new release? I'll certainly do that.
nix-rust/nix@652e730

@alexcrichton
Copy link
Contributor

Yeah once there's a new release of nix we can pull that in.

@posborne
Copy link
Contributor

Since there are semver breaking changes in a few places, we are probably looking at a release 0.8.0 as the next release of nix. We don't have a solid date on that in mind right now, but if there is urgency we can probably look to expedite. I am doing a pass through nix improving (or just adding) documentation across the board which has led to some API changes where things were either broken or doing users no service.

@alexcrichton
Copy link
Contributor

@posborne sounds good to me! AFAIK there's no burning desire to get this updated, so mio can just update whenever 0.8.0 is released

@carllerche
Copy link
Member

The dependency on nix was removed as we weren't using much of it anyway and we ended up with custom bits.

@carllerche carllerche closed this Jan 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants