opcode: add RecvMsgMulti #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I used some spacing in the documentation for the parameters. I don't know how that will look when it is actually rendered. |
lucab
reviewed
Feb 17, 2023
src/opcode.rs
Outdated
| #[derive(Debug)] | ||
| pub struct RecvMsgMulti { | ||
| fd: { impl sealed::UseFixed }, | ||
| msg: { *mut libc::msghdr }, |
There was a problem hiding this comment.
I think this doesn't strictly need to be mut.
quininer
reviewed
Feb 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the RecvMsgMulti opcode.
Updated the unit test to use it.
Also fixes the RecvMsg handling of the seq.flags field. It wouldn't have handled a fixed file descriptor.
Also improves the documentation to RecvMsg, to better describe the buf_group parameter and the Multi aspect of the operation.