Implement Buf for std::io::Take<&[u8]>. #229
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarnach
force-pushed
the
smarnach/impl-buf-for-take
branch
from
1434b2f to
3e0541d
Compare
|
The build fails for Rust 1.15, which does not yet have the new methods. So if this version of Rust still needs to be supported, we need to protect this by a feature flag, which probably isn't worth it. |
|
I will track this for the next breaking change 👍 Thanks. |
smarnach
force-pushed
the
smarnach/impl-buf-for-take
branch
from
3e0541d to
a1a7768
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I stumbled upon rust-lang/rust#27269 and noticed that it is fixed now, so I added an implementation. The implementation only covers
Take<&[u8]>, but I can't think of any more general type this could be implemented for.