Use of num-parse to parse integers
#65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To simplify parseInt()-/parseFloat()-style value extraction from strings, a new crate num-parse was started to provide a generic implementation for this.
This commit allows to use num_parse to implement the Int token without headaches. Previous experiments failed as the Reader was wrapped by a Peekable, which doesn't work. There should be some improvement on Reader as well regarding the internal input buffing, which is a little crank.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
num-parse-crate was established from the requirement that there is no existing JavaScript-likeparseInt()orparseFloat()method in Rust.This crate is developed apart from Tokay, but Tokay makes both use of it in terms of the internal string-to-int-conversion functions as well as the
Int-token. For this case, theReaderneeded to be modified to implementPeekableIteratorfromnum-parseto use equal parsing features in all cases.num-parsewill be extended to support aparse_float()as well, which will be integrated into Tokay as well then.