Implement mkdtemp primitive on Windows #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
floitsch
approved these changes
Jan 17, 2022
Comment on lines
+332
to
+336
| bool in_standard_tmp_dir = false; | ||
| if (strncmp(prefix, "/tmp/", 5) == 0) { | ||
| in_standard_tmp_dir = true; | ||
| prefix += 5; | ||
| } |
There was a problem hiding this comment.
I don't think you need to check for that.
The prefix should just be a prefix for the tmp directory.
For example, some of the directories created with lsp_repro- prefix:
lsp_repro-0uHt7f
lsp_repro-1fl2A8
lsp_repro-1I2HYr
lsp_repro-1sPJA6
lsp_repro-1vUdC9
lsp_repro-4jTjLL
lsp_repro-4v3TB7
lsp_repro-5GbI7q
lsp_repro-66nfUl
lsp_repro-6gdWvL
It's actually called "template" for the C function.
If we allow a full path in the C version, then we should probably fix that instead.
There was a problem hiding this comment.
The ar test uses a full path as the prefix.
There was a problem hiding this comment.
oops.
Should change the test...
There was a problem hiding this comment.
After some offline discussion we agreed it was enough to document the current behaviour.
added 8 commits
January 17, 2022 07:28
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.