Skip to content
This repository has been archived by the owner on Feb 4, 2023. It is now read-only.

Update universalJavaApplicationStub #81

Closed
wants to merge 1 commit into from

Conversation

thatChadM
Copy link
Contributor

Tweaked the java8pattern to accept more than just 1.[4-8].0 since I ran into an application that listed 1.4.2+ as the required version.

What kind of change does this PR introduce? (Bug fix, feature, docs update, other)
No longer assumes that the third part of the version string will always be .0 or .0_. Now supports .## or .0_something.

Tweak the java8pattern to accept more than just 1.[4-8].0 since I have an application that lists 1.4.2+ as the required version.
@tofi86
Copy link
Owner

tofi86 commented Feb 11, 2020

Thank you very much for your contribution! 👏 I appreciate this!

I cherry-picked your fix to the current develop branch with 2b9f42f and updated the tests 5bfefdd accordingly.

Therefore I'm going to close this MR unmerged.

@tofi86 tofi86 closed this Feb 11, 2020
@tofi86 tofi86 self-assigned this Feb 11, 2020
@tofi86 tofi86 added the patch label Feb 11, 2020
@tofi86 tofi86 added this to the Version 3.0.6 milestone Feb 11, 2020
@tofi86 tofi86 mentioned this pull request Mar 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants