Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: add @typescript-eslint/return-await rule #9612

Merged

Conversation

Brooooooklyn
Copy link
Member

No description provided.

@github-actions github-actions bot added mod:infra Environment related issues and discussions app:electron Related to electron app app:core labels Jan 9, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 52.83%. Comparing base (6d29f80) to head (fed0156).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
...mon/infra/src/sync/indexer/impl/indexeddb/index.ts 50.00% 1 Missing ⚠️
...s/frontend/core/src/modules/cloud/services/auth.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9612      +/-   ##
==========================================
+ Coverage   52.80%   52.83%   +0.03%     
==========================================
  Files        2180     2180              
  Lines       98431    98431              
  Branches    16690    16690              
==========================================
+ Hits        51974    52010      +36     
+ Misses      45045    44971      -74     
- Partials     1412     1450      +38     
Flag Coverage Δ
server-test 77.77% <ø> (ø)
unittest 32.36% <33.33%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Jan 9, 2025

Merge activity

@Brooooooklyn Brooooooklyn force-pushed the 01-09-style_add_typescript-eslint_return-await_rule branch from d562c7f to fed0156 Compare January 9, 2025 09:29
@graphite-app graphite-app bot merged commit fed0156 into canary Jan 9, 2025
61 checks passed
@graphite-app graphite-app bot deleted the 01-09-style_add_typescript-eslint_return-await_rule branch January 9, 2025 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core app:electron Related to electron app mod:infra Environment related issues and discussions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants