Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing annotation to apps serviceAccount #10484

Merged

Conversation

Brooooooklyn
Copy link
Member

No description provided.

@graphite-app graphite-app bot requested a review from a team February 27, 2025 08:35
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Brooooooklyn Brooooooklyn force-pushed the 02-27-fix_add_missing_annotation_to_apps_serviceaccount branch from c9486f8 to 8f04bd4 Compare February 27, 2025 08:37
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.31%. Comparing base (1fd3d61) to head (a203e5f).
Report is 4 commits behind head on canary.

Additional details and impacted files
@@            Coverage Diff             @@
##           canary   #10484      +/-   ##
==========================================
- Coverage   54.57%   54.31%   -0.27%     
==========================================
  Files        2341     2341              
  Lines      108231   108234       +3     
  Branches    17952    17907      -45     
==========================================
- Hits        59071    58789     -282     
- Misses      47852    48112     +260     
- Partials     1308     1333      +25     
Flag Coverage Δ
server-test 78.98% <ø> (-0.71%) ⬇️
unittest 31.24% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Brooooooklyn Brooooooklyn force-pushed the 02-27-fix_add_missing_annotation_to_apps_serviceaccount branch from 8f04bd4 to 735b2c5 Compare February 27, 2025 08:47
@Brooooooklyn Brooooooklyn force-pushed the 02-27-fix_add_missing_annotation_to_apps_serviceaccount branch from 735b2c5 to a203e5f Compare February 27, 2025 08:48
@forehalo forehalo merged commit fc4a716 into canary Feb 27, 2025
66 checks passed
Copy link

graphite-app bot commented Feb 27, 2025

Merge activity

@forehalo forehalo deleted the 02-27-fix_add_missing_annotation_to_apps_serviceaccount branch February 27, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants