Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Docker Publishing #206

Merged
merged 2 commits into from
Mar 25, 2021
Merged

Update Docker Publishing #206

merged 2 commits into from
Mar 25, 2021

Conversation

lindluni
Copy link
Contributor

@lindluni lindluni commented Mar 25, 2021

This PR updates the short SHA of one of the actions to a versioned tag now that it exists. Actions no longer supports the short SHA for a named Action, as such post-merge CI is failing as it cannot checkout the Action.

This change also migrates from the custom PAT_TOKEN to the GITHUB_TOKEN now that the GHCR supports the GITHUB_TOKEN for push event authentication to the registry: https://github.blog/changelog/2021-03-24-packages-container-registry-now-supports-github_token/

GitHub Actions no longer supports a short SHA
as the version of an Action. The Action in question
has published a tag now so that can be used directly.

Signed-off-by: Brett Logan <[email protected]>
The GitHub Container Registry now supports
the use of the GITHUB_TOKEN for pushing to
a container registry on push events, switch
to using this token as oppossed to the
custome PAT_TOKEN.

Signed-off-by: Brett Logan <[email protected]>
@lindluni lindluni requested a review from trevmex as a code owner March 25, 2021 01:15
@caniszczyk caniszczyk merged commit 0149029 into todogroup:master Mar 25, 2021
@github-actions
Copy link

🎉 This PR is included in version 0.10.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants