Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: parse inline comments #397

Merged
merged 1 commit into from
Dec 16, 2024
Merged

feat: parse inline comments #397

merged 1 commit into from
Dec 16, 2024

Conversation

k-yle
Copy link
Collaborator

@k-yle k-yle commented Dec 11, 2024

Closes #272

Because of #393, the next release will already be a potential breaking change for .env.* files that include a # symbol on the same line as key/value pair.

So, this might be a good opportunity to resolve another long-standing inconsistency between this repository and other .env tools. Specifically: inline comment support.

Tools/libraries that support inline comments in .env files:

Tools/library that do not support inline comments:

  • env-cmd
  • others?

Copy link
Owner

@toddbluhm toddbluhm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Nice work!

Obviously, this is a breaking change, but we got lots of those in v11 already!

@k-yle k-yle merged commit bcd9f59 into master Dec 16, 2024
18 checks passed
@k-yle k-yle deleted the kh/inline-comments branch December 16, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider inline comments for .env files
2 participants