Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define build-matrix for RazorLight #299

Closed
jzabroski opened this issue Dec 17, 2019 · 1 comment · Fixed by #407
Closed

Define build-matrix for RazorLight #299

jzabroski opened this issue Dec 17, 2019 · 1 comment · Fixed by #407
Milestone
2.0.0-rc.4

Comments

@jzabroski
Copy link
Collaborator

@toddams It seems OrchardCMS has defined a build matrix explaining some of the ways they configure things: OrchardCMS/OrchardCore#1156 (comment)

Their scenario is similar, in that they support non Razor.

This might be a rabbit trail but my thought is there are a bunch of different knobs we're turning to get RazorLight to work right, all for difference reasons.
@jzabroski jzabroski pinned this issue Dec 20, 2019
@jzabroski jzabroski mentioned this issue Dec 20, 2019
Open
This was referenced Apr 15, 2020
Closed
Open
@jzabroski jzabroski mentioned this issue Jul 29, 2020
Open
@jzabroski
Copy link
Collaborator Author

Made real progress today on this issue by setting up GitHub Actions and configuring a build matrix for [ windows-latest, ubuntu-latest, macos-latest ].

The downside to this new set-up is that windows-latest takes the longest, because it is additionally testing net472 whereas ubuntu-latest and macos-latest don't test net472.

jzabroski added a commit that referenced this issue Jan 4, 2021
@jzabroski
Fixes #299
d0b47d6
@jzabroski jzabroski added this to the 2.0.0-rc.4 milestone Jan 4, 2021
@jzabroski jzabroski mentioned this issue Jan 4, 2021
Merged
@jzabroski jzabroski unpinned this issue Jan 4, 2021
@jzabroski jzabroski mentioned this issue Jan 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0-rc.4
Development

Successfully merging a pull request may close this issue.

Directly support .NET Fx 4.7.2 via unit tests toddams/RazorLight
1 participant
@jzabroski