Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update instructions for configuring nginx behind ELB, add for sinatra #96

Merged
merged 1 commit into from
May 18, 2017

Conversation

bmishkin
Copy link
Contributor

@bmishkin bmishkin commented May 3, 2017

I recently configured a sinatra app using rack-ssl-enforcer using an ELB with only port 80 terminated on the server(s) in nginx. Wanted to contrib my updates => README.

changes:

  • proxy_set_header X-Forwarded-Proto $http_x_forwarded_proto; instead of $scheme; - because $scheme is already set to http by the time requests reach nginx. We want to forward on the $http_x_forwarded_proto set by the ELB.
  • Added one-line example for sinatra.
  • Reformatted nginx example block.

@tobmatth tobmatth merged commit 240e8b7 into tobmatth:master May 18, 2017
@tobmatth
Copy link
Owner

Thanks for your contribution, merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants