Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user agent support #59

Merged
merged 4 commits into from
Sep 6, 2013
Merged

Add user agent support #59

merged 4 commits into from
Sep 6, 2013

Conversation

carmstrong
Copy link
Contributor

Adds support for user agents -- patterns can be specified with only_agents or except_agents.

@carmstrong
Copy link
Contributor Author

Anyone have any insight as to why this failed for ruby head only?

@rymai
Copy link
Collaborator

rymai commented Sep 5, 2013

Yeah, it cannot find bundler, it's a common issue these days (I never really searched the real cause).

If you rebase your branch on master, I've now allowed ruby-head to fail on TravisCI without failing the entire build.

@carmstrong
Copy link
Contributor Author

Thanks. Rebased and pushed.

@rymai
Copy link
Collaborator

rymai commented Sep 6, 2013

Thanks, sorry I messed up and everything was failing on TravisCI! :P That's fixed now.

Anyways, could you also document the new feature in the README before I merge this PR?

Thanks in advance!

@carmstrong
Copy link
Contributor Author

Done. I also listed myself as a contributor in the README - not sure if this qualifies me as a contributor. I can certainly remove it if not.

@rymai
Copy link
Collaborator

rymai commented Sep 6, 2013

Thanks! Regarding the contributors, I'll actually replace the hardcoded list with a link to https://github.com/tobmatth/rack-ssl-enforcer/graphs/contributors, it'll scale better!

rymai added a commit that referenced this pull request Sep 6, 2013
@rymai rymai merged commit 76bb34e into tobmatth:master Sep 6, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants