Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug that was setting arrays as keys in default_options hash #50

Merged
merged 1 commit into from
May 3, 2013
Merged

fix bug that was setting arrays as keys in default_options hash #50

merged 1 commit into from
May 3, 2013

Conversation

wyattisimo
Copy link
Contributor

Lines 26-28 in lib/rack/ssl-enforcer.rb are causing the default_options hash to look like this:

{
  :redirect_to => nil,
  :redirect_code => nil,
  :strict => false,
  :mixed => false,
  :hsts => nil,
  :http_port => nil,
  :https_port => nil,
  :force_secure_cookies => true,
  [:only_hosts, :except_hosts] => nil,
  [:only, :except] => nil,
  [:only_methods, :except_methods] => nil
}

This fixes it to look like this:

{
  :redirect_to => nil,
  :redirect_code => nil,
  :strict => false,
  :mixed => false,
  :hsts => nil,
  :http_port => nil,
  :https_port => nil,
  :force_secure_cookies => true,
  :only_hosts => nil,
  :except_hosts => nil,
  :only => nil,
  :except => nil,
  :only_methods => nil,
  :except_methods => nil
}

@rymai
Copy link
Collaborator

rymai commented May 3, 2013

RIght, thank you!

rymai added a commit that referenced this pull request May 3, 2013
Fix bug that was setting arrays as keys in default_options hash
@rymai rymai merged commit 91c7234 into tobmatth:master May 3, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants