Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixing microsecond precision constant for v1 (#49) #47

Merged
merged 3 commits into from
Apr 17, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,13 @@
# Changelog
## Version 3.x.x
- [FIX] Compilation error on fields order (#43)
- [FIX] Invalid precision constant for microseconds (#49)

## Version 3.1.1
- [Updated] CA Certificate for SSL (#38)

## Version 3.1.0
- [NEW] user-agent header added
- [NEW] Added User-agent header
- [FIX] status code check when pinging an InfluxDB version 1.x instance

## Version 3.0.0
Expand Down
6 changes: 3 additions & 3 deletions src/InfluxDbClient.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,10 @@ static String escapeKey(String key);
static String escapeValue(const char *value);
static String escapeJSONString(String &value);

static String precisionToString(WritePrecision precision) {
static String precisionToString(WritePrecision precision, uint8_t version = 2) {
switch(precision) {
case WritePrecision::US:
return "us";
return version==1?"u":"us";
case WritePrecision::MS:
return "ms";
case WritePrecision::NS:
Expand Down Expand Up @@ -266,7 +266,7 @@ void InfluxDBClient::setUrls() {
}
}
if(_writePrecision != WritePrecision::NoTime) {
_writeUrl += String("&precision=") + precisionToString(_writePrecision);
_writeUrl += String("&precision=") + precisionToString(_writePrecision, _dbVersion);
}

}
Expand Down
12 changes: 11 additions & 1 deletion test/server/server.js
Original file line number Diff line number Diff line change
Expand Up @@ -231,26 +231,36 @@ function handleAuthentication(req, res) {
}
}

const AllowedPrecisions = ['ns','us','ms','s'];
function checkWriteParams(req, res) {
var org = req.query['org'];
var bucket = req.query['bucket'];
var precision = req.query['precision'];
if(org != 'my-org') {
res.status(404).send(`{"code":"not found","message":"organization name \"${org}\" not found"}`);
return false;
} else if(bucket != 'my-bucket') {
res.status(404).send(`{"code":"not found","message":"bucket \"${bucket}\" not found"}`);
return false;
} else if(typeof precision !== 'undefined' && AllowedPrecisions.indexOf(precision)==-1) {
res.status(400).send(`{"code":"bad request ","message":"precision \"${precision}\" is not valid"}`);
return false;
} else {
return true;
}
}

const AllowedPrecisionsV1 = ['ns','u','ms','s'];
function checkWriteParamsV1(req, res) {
var db = req.query['db'];
var precision = req.query['precision'];
if(db != 'my-db') {
res.status(404).send(`{"code":"not found","message":"database \"${db}\" not found"}`);
return false;
} else {
} else if(typeof precision !== 'undefined' && AllowedPrecisionsV1.indexOf(precision)==-1) {
res.status(400).send(`{"code":"bad request ","message":"precision \"${precision}\" is not valid"}`);
return false;
}else {
return true;
}
}
Expand Down
18 changes: 18 additions & 0 deletions test/test.ino
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,15 @@ void testBasicFunction() {
String q = queryFlux(client.getServerUrl(),INFLUXDB_CLIENT_TESTING_TOK, INFLUXDB_CLIENT_TESTING_ORG, query);
TEST_ASSERT(countLines(q) == 6); //5 points+header

// test precision
for (int i = (int)WritePrecision::NoTime; i <= (int)WritePrecision::NS; i++) {
client.setWriteOptions((WritePrecision)i, 1);
Point *p = createPoint("test1");
p->addField("index", i);
TEST_ASSERTM(client.writePoint(*p), String("i=") + i);
delete p;
}

TEST_END();
deleteAll(INFLUXDB_CLIENT_TESTING_URL);
}
Expand Down Expand Up @@ -768,6 +777,15 @@ void testV1() {
q = queryFlux(client.getServerUrl(),INFLUXDB_CLIENT_TESTING_TOK, INFLUXDB_CLIENT_TESTING_ORG, query);
lines = getLines(q, count);
TEST_ASSERT(count == 16);

// test precision
for (int i = (int)WritePrecision::NoTime; i <= (int)WritePrecision::NS; i++) {
client.setWriteOptions((WritePrecision)i, 1);
Point *p = createPoint("test1");
p->addField("index", i);
TEST_ASSERTM(client.writePoint(*p), String("i=") + i);
delete p;
}
TEST_END();
deleteAll(INFLUXDB_CLIENT_TESTING_URL);
}
Expand Down