Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bedrock: Fix unchecked error when stream channel is closed #998

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

lucaronca
Copy link
Contributor

@lucaronca lucaronca commented Aug 21, 2024

PR Checklist

  • Read the Contributing documentation.
  • Read the Code of conduct documentation.
  • Name your Pull Request title clearly, concisely, and prefixed with the name of the primarily affected package you changed according to Good commit messages (such as memory: add interfaces for X, Y or util: add whizzbang helpers).
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. Fixes #123).
  • Describes the source of new concepts.
  • References existing implementations as appropriate.
  • Contains test coverage for new functions.
  • Passes all golangci-lint checks.

As you can see in the aws sdk, when an error is set then stream channel is closed:

The stream channel was read, but once closed, the error was not checked.
You can reproduce a bug triggering a streaming completion response and cancelling the context. The context.Canceled error is not returned.
I'm adding it just for anthropic provider because is the only one that supports streaming at present.

@lucaronca lucaronca changed the title bedrock: fix unchecked error when stream channel is closed fix(bedrock): fix unchecked error when stream channel is closed Sep 3, 2024
@lucaronca lucaronca changed the title fix(bedrock): fix unchecked error when stream channel is closed fix(bedrock): Fix unchecked error when stream channel is closed Sep 3, 2024
@lucaronca lucaronca force-pushed the lucaronca/fix-bedrock-stream-cancel branch from af342a6 to 9fe0d83 Compare September 3, 2024 13:27
@tmc tmc changed the title fix(bedrock): Fix unchecked error when stream channel is closed bedrock: Fix unchecked error when stream channel is closed Sep 13, 2024
Copy link
Owner

@tmc tmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should cover in test but LGTM

@tmc tmc merged commit 17d9e48 into tmc:main Sep 13, 2024
3 checks passed
@lucaronca lucaronca deleted the lucaronca/fix-bedrock-stream-cancel branch September 13, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants