Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #974 - returning score driven by cosine similarity by (1 - distance) instead of distance #1048

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

avi3tal
Copy link
Contributor

@avi3tal avi3tal commented Oct 14, 2024

PR Checklist

  • Read the Contributing documentation.
  • Read the Code of conduct documentation.
  • Name your Pull Request title clearly, concisely, and prefixed with the name of the primarily affected package you changed according to Good commit messages (such as memory: add interfaces for X, Y or util: add whizzbang helpers).
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. Fixes #123).
  • Describes the source of new concepts.
  • References existing implementations as appropriate.
  • Contains test coverage for new functions.
  • Passes all golangci-lint checks.

@avi3tal
Copy link
Contributor Author

avi3tal commented Oct 14, 2024

The current implementation has returned the distance instead of the desired score
Therefore and following pgvector doc, ww had to change the distance by score

@avi3tal avi3tal changed the title Fixing the returned value of cosine similarity by (1 - distance) Fixes #974 - returning score driven by cosine similarity by (1 - distance) instead of distance Oct 15, 2024
Copy link
Owner

@tmc tmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tmc tmc merged commit 238d1c7 into tmc:main Oct 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants