Add back intenral EE APIs used by the debugger until the debugger swi…

…tches to the new overloads (dotnet#76912)
tmat · Jan 28, 2025 · 674bc5d · 674bc5d
1 parent 0597bbf
commit 674bc5d
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 10 deletions.
diff --git a/src/ExpressionEvaluator/CSharp/Source/ExpressionCompiler/EvaluationContext.cs b/src/ExpressionEvaluator/CSharp/Source/ExpressionCompiler/EvaluationContext.cs
@@ -91,6 +91,17 @@ internal static EvaluationContext CreateTypeContext(
                 methodDebugInfo: MethodDebugInfo<TypeSymbol, LocalSymbol>.None);
         }
 
+        // Used by VS debugger (/src/debugger/ProductionDebug/CodeAnalysis/CodeAnalysis/ExpressionEvaluator.cs)
+        internal static EvaluationContext CreateMethodContext(
+            ImmutableArray<MetadataBlock> metadataBlocks,
+            object symReader,
+            Guid moduleId,
+            int methodToken,
+            int methodVersion,
+            uint ilOffset,
+            int localSignatureToken)
+            => CreateMethodContext(metadataBlocks, symReader, new ModuleId(moduleId, "<unknown>"), methodToken, methodVersion, ilOffset, localSignatureToken);
+
         /// <summary>
         /// Create a context for evaluating expressions within a method scope.
         /// </summary>

diff --git a/src/ExpressionEvaluator/Core/Source/ExpressionCompiler/MetadataBlock.cs b/src/ExpressionEvaluator/Core/Source/ExpressionCompiler/MetadataBlock.cs
@@ -12,34 +12,32 @@ namespace Microsoft.CodeAnalysis.ExpressionEvaluator
     /// Module metadata block
     /// </summary>
     [DebuggerDisplay("{GetDebuggerDisplay(), nq}")]
-    internal readonly struct MetadataBlock : IEquatable<MetadataBlock>
+    internal readonly struct MetadataBlock(ModuleId moduleId, Guid generationId, IntPtr pointer, int size) : IEquatable<MetadataBlock>
     {
         /// <summary>
         /// Module id.
         /// </summary>
-        internal readonly ModuleId ModuleId;
+        internal readonly ModuleId ModuleId = moduleId;
 
         /// <summary>
         /// Module generation id.
         /// </summary>
-        internal readonly Guid GenerationId;
+        internal readonly Guid GenerationId = generationId;
 
         /// <summary>
         /// Pointer to memory block managed by the caller.
         /// </summary>
-        internal readonly IntPtr Pointer;
+        internal readonly IntPtr Pointer = pointer;
 
         /// <summary>
         /// Size of memory block.
         /// </summary>
-        internal readonly int Size;
+        internal readonly int Size = size;
 
-        internal MetadataBlock(ModuleId moduleId, Guid generationId, IntPtr pointer, int size)
+        // Used by VS debugger (/src/debugger/ProductionDebug/CodeAnalysis/CodeAnalysis/ExpressionEvaluator.cs)
+        internal MetadataBlock(Guid moduleId, Guid generationId, IntPtr pointer, int size)
+            : this(new ModuleId(moduleId, "<unknown>"), generationId, pointer, size)
         {
-            ModuleId = moduleId;
-            GenerationId = generationId;
-            Pointer = pointer;
-            Size = size;
         }
 
         public bool Equals(MetadataBlock other)