-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional test vectors for the RSA implicit rejection #541
Conversation
add more tests, make formatting consistent with the values in the IETF draft
ab482f3
to
36dcaae
Compare
using multiline literals seems unnecessary for such short values |
I don't see this one in https://github.com/tomato42/marvin-ietf/blob/d911d9a31654aa619a57bb0a970a2185e763b29b/draft-irtf-cfrg-rsa-guidance.xml, is that OK? same for several more; they're not new in this PR |
nit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: 0 of 2 files reviewed, 3 unresolved discussions (waiting on @tomato42)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, 3 unresolved discussions (waiting on @t184256)
unit_tests/test_tlslite_utils_rsakey.py
line 1822 at r6 (raw file):
Previously, t184256 (Alexander Sosedkin) wrote…
nit:
all(i != 0 for i in N)
looks overly verbose to me given it could be anall(N)
, but that's a matter of preference
while yes, I wanted it to be understandable to people with just cursory understanding of Python
unit_tests/test_tlslite_utils_rsakey.py
line 3087 at r6 (raw file):
Previously, t184256 (Alexander Sosedkin) wrote…
I don't see this one in https://github.com/tomato42/marvin-ietf/blob/d911d9a31654aa619a57bb0a970a2185e763b29b/draft-irtf-cfrg-rsa-guidance.xml, is that OK? same for several more; they're not new in this PR
yes, it's ok, I don't think it's strictly necessary or brings much above a single null byte at the beginning; for the I-D I've selected a subset that should catch most of issues
unit_tests/test_tlslite_utils_rsakey.py
line 3204 at r6 (raw file):
Previously, t184256 (Alexander Sosedkin) wrote…
using multiline literals seems unnecessary for such short values
while true, I wanted them to be easily diffable with the xml source of the I-D and then later, the RFC
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, all discussions resolved
More vectors and align them with the draft-irtf-cfrg-rsa-guidance
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)