Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate the TiffImages engine #92

Merged
merged 3 commits into from
Oct 21, 2021
Merged

Integrate the TiffImages engine #92

merged 3 commits into from
Oct 21, 2021

Conversation

tlnagy
Copy link
Owner

@tlnagy tlnagy commented Oct 20, 2021

This rips out all the TIFF specific code in OMETIFF.jl and replaces it with the TiffImages.jl engine. There are also miscellaneous minor improvements to UUID tracking as well. This should bring a lot of the performance and flexibility of TiffImages including BigTIFF support and ability to open a much larger gamut of TIFF files.

  • Requires TiffImages.jl v0.5

Fixes #12, fixes #71, fixes #68

Working on #82

This rips out all the TIFF specific code in OMETIFF.jl and replaces it
with TiffImages.jl engine. This keeps the OMETIFF specific functions.
There are also miscellaneous minor improvements to UUID tracking as
well.
@tlnagy tlnagy closed this Oct 20, 2021
@tlnagy tlnagy reopened this Oct 20, 2021
@codecov
Copy link

codecov bot commented Oct 20, 2021

Codecov Report

Merging #92 (e4bb73e) into master (6f3555e) will decrease coverage by 0.57%.
The diff coverage is 98.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #92      +/-   ##
==========================================
- Coverage   95.65%   95.07%   -0.58%     
==========================================
  Files           6        6              
  Lines         345      264      -81     
==========================================
- Hits          330      251      -79     
+ Misses         15       13       -2     
Impacted Files Coverage Δ
src/OMETIFF.jl 100.00% <ø> (ø)
src/utils.jl 100.00% <ø> (+12.00%) ⬆️
src/files.jl 92.92% <98.03%> (-2.50%) ⬇️
src/loader.jl 95.08% <100.00%> (-3.43%) ⬇️
src/mmap.jl 94.73% <100.00%> (+3.82%) ⬆️
src/parsing.jl 97.50% <100.00%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f3555e...e4bb73e. Read the comment docs.

@tlnagy tlnagy merged commit eca5a47 into master Oct 21, 2021
@tlnagy tlnagy deleted the tn/use-tiffimages branch October 21, 2021 18:42
tlnagy added a commit that referenced this pull request Oct 22, 2021
this was an oversight in #92
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant