Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repl mode #222

Merged
merged 14 commits into from
Jul 13, 2023
Merged

Repl mode #222

merged 14 commits into from
Jul 13, 2023

Conversation

tlienart
Copy link
Owner

@tlienart tlienart commented Jul 11, 2023

closes #123
closes #219
closes #226 (force re-eval if anything changes in the block, this should be the case even if we evaluate line by line)

moved the error test stuff to #230

  • basic repl-repl ok
  • basic repl-shell ok
  • basic repl-pkg ok
  • basic repl-help single line ok
  • test repl-repl error (incomplete ast)
  • test repl-repl error (julia error)
  • test repl-pkg error
  • test repl-shell error
  • test repl-help multiline
  • test repl-help unknown
  • examples in doc
    • repl-repl
    • repl-shell
    • repl-pkg
    • repl-help

Note: repl-repl julia error handling requires tweaking eval_code_cell! which calls eval_code_cell which calls eval_nb_cell, _process_eval_error, a repl argument should be passed to allow the error, not warn, not throw, and show the trimmed error. ok done

@github-actions
Copy link

Preview should be up in a couple of mins at
https://tlienart.github.io/Xranklin.jl/previews/PR222
(if you get a 404, wait 30s then refresh).

@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2023

Codecov Report

Patch coverage: 86.92% and project coverage change: +0.01 🎉

Comparison is base (395fb1d) 83.42% compared to head (a247b43) 83.44%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #222      +/-   ##
==========================================
+ Coverage   83.42%   83.44%   +0.01%     
==========================================
  Files          66       66              
  Lines        3385     3491     +106     
==========================================
+ Hits         2824     2913      +89     
- Misses        561      578      +17     
Impacted Files Coverage Δ
src/Xranklin.jl 26.31% <ø> (ø)
src/build/build_loop.jl 0.00% <ø> (ø)
src/context/notebook.jl 100.00% <ø> (ø)
src/convert/postprocess/hfuns/hyperref.jl 78.26% <0.00%> (-0.87%) ⬇️
src/build/full_pass.jl 82.41% <69.23%> (-0.93%) ⬇️
src/convert/markdown/rules/code.jl 84.32% <86.51%> (+2.03%) ⬆️
src/build/serve.jl 86.41% <100.00%> (ø)
src/build/watch.jl 98.30% <100.00%> (+0.02%) ⬆️
src/context/code/eval.jl 94.87% <100.00%> (+0.13%) ⬆️
src/context/code/notebook_code.jl 76.92% <100.00%> (+0.17%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

Preview should be up in a couple of mins at
https://tlienart.github.io/Xranklin.jl/previews/PR222
(if you get a 404, wait 30s then refresh).

2 similar comments
@github-actions
Copy link

Preview should be up in a couple of mins at
https://tlienart.github.io/Xranklin.jl/previews/PR222
(if you get a 404, wait 30s then refresh).

@github-actions
Copy link

Preview should be up in a couple of mins at
https://tlienart.github.io/Xranklin.jl/previews/PR222
(if you get a 404, wait 30s then refresh).

@github-actions
Copy link

Preview should be up in a couple of mins at
https://tlienart.github.io/Xranklin.jl/previews/PR222
(if you get a 404, wait 30s then refresh).

@github-actions
Copy link

Preview should be up in a couple of mins at
https://tlienart.github.io/Xranklin.jl/previews/PR222
(if you get a 404, wait 30s then refresh).

@github-actions
Copy link

Preview should be up in a couple of mins at
https://tlienart.github.io/Xranklin.jl/previews/PR222
(if you get a 404, wait 30s then refresh).

1 similar comment
@github-actions
Copy link

Preview should be up in a couple of mins at
https://tlienart.github.io/Xranklin.jl/previews/PR222
(if you get a 404, wait 30s then refresh).

@github-actions
Copy link

Preview should be up in a couple of mins at
https://tlienart.github.io/Xranklin.jl/previews/PR222
(if you get a 404, wait 30s then refresh).

@github-actions
Copy link

Preview should be up in a couple of mins at
https://tlienart.github.io/Xranklin.jl/previews/PR222
(if you get a 404, wait 30s then refresh).

@github-actions
Copy link

Preview should be up in a couple of mins at
https://tlienart.github.io/Xranklin.jl/previews/PR222
(if you get a 404, wait 30s then refresh).

1 similar comment
@github-actions
Copy link

Preview should be up in a couple of mins at
https://tlienart.github.io/Xranklin.jl/previews/PR222
(if you get a 404, wait 30s then refresh).

@github-actions
Copy link

Preview should be up in a couple of mins at
https://tlienart.github.io/Xranklin.jl/previews/PR222
(if you get a 404, wait 30s then refresh).

@tlienart tlienart merged commit b73cd4f into main Jul 13, 2023
@github-actions
Copy link

Preview should be up in a couple of mins at
https://tlienart.github.io/Xranklin.jl/previews/PR222
(if you get a 404, wait 30s then refresh).

@tlienart tlienart deleted the tl/replmode branch July 17, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

repl mode order of cells repl mode REPL mode
2 participants