Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make div_content settable from a page #984

Merged
merged 1 commit into from
Oct 11, 2022

Conversation

stanvanlier
Copy link
Contributor

Fixes #983

@tlienart tlienart merged commit d6f2303 into tlienart:master Oct 11, 2022
@tlienart
Copy link
Owner

Thanks!!

@tlienart
Copy link
Owner

Ps: do you need a patch release with this or are you ok to work with master for now?

@stanvanlier
Copy link
Contributor Author

Yes would like to deploy using gitlab ci, or is that also possible with master?

@tlienart
Copy link
Owner

It is, the only difference is that in the gitlab script you'll have to install a specific version with something like

using Pkg
Pkg.add(PackageSpec(name="Franklin", rev="master"))
using Franklin
Franklin.optimize(...)

as opposed to just putting Franklin in the Project toml.

Happy to do a patch release as well, might do that within 24h anyway

@stanvanlier
Copy link
Contributor Author

Ah ok thanks! I'll use master for now then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to set div_content with local page variable
2 participants