Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New section on previews using GH Actions + update outdated deployment workflows #982

Merged
merged 6 commits into from
Oct 19, 2022
Merged

New section on previews using GH Actions + update outdated deployment workflows #982

merged 6 commits into from
Oct 19, 2022

Conversation

Saransh-cpp
Copy link
Contributor

Closes #980

This PR -

  • Adds a new section on how to deploy previews using GH Actions
  • Adds a new section on using new GH Pages workflows
  • Updates the version and syntax of actions used in the deployment workflow
  • Fixes minor styling and grammatical errors

TODO:

tlienart
tlienart approved these changes Oct 11, 2022
View reviewed changes
Copy link
Owner

@tlienart tlienart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wonderful, thanks a lot, just a minor request and will wait until you've added the link to your repo then good to merge 🙌

@Saransh-cpp
Copy link
Contributor Author

Thanks for the review, @tlienart! I will update the example as soon as the port is complete!

@Saransh-cpp Saransh-cpp mentioned this pull request Oct 12, 2022
Closed
@Saransh-cpp
Copy link
Contributor Author

@tlienart, this should be ready now! I have added FluxML's website as an example.

@tlienart tlienart merged commit 70ebf68 into tlienart:master Oct 19, 2022
@tlienart
Copy link
Owner

thanks a lot!

@Saransh-cpp Saransh-cpp deleted the gh-pages-previews branch October 19, 2022 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlienart tlienart tlienart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rendering and deploying previews using GitHub
2 participants
@Saransh-cpp @tlienart